feat(properties) Support custom properties on all entities with profile page #10680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asikowitz
approved these changes
Jun 11, 2024
chriscollins3456
force-pushed
the
cc--cus-1565-custom-properties
branch
from
c57857d
to
8fd29f2
Compare
chriscollins3456
merged commit 54ba014
into
datahub-project:master
61 of 63 checks passed
sleeperdeep
pushed a commit
to sleeperdeep/datahub
that referenced
this pull request
Jun 25, 2024
yoonhyejin
pushed a commit
that referenced
this pull request
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for the remaining entity types that didn't have custom properties included in their PDL models (out of the entity types that have a profile page). These profile pages already have the
PropertiesTabon them, so this just needed a PDL model change.Checklist