Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(openapi): openapi v3 updates #10710

Merged
merged 1 commit into from
Jun 14, 2024
Merged

feat(openapi): openapi v3 updates #10710

merged 1 commit into from
Jun 14, 2024

Conversation

david-leifker
Copy link
Collaborator

  • Added flag to HEAD endpoint to consider (or not) soft deleted entities
  • GET operations will no longer return default key aspects (instead 404)
    • reflects whether the entity actually exists in the database
  • better error messages on invalid urns
  • refactor generic controller from models to servlet

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added product PR or Issue related to the DataHub UI/UX devops PR or Issue related to DataHub backend & deployment labels Jun 14, 2024
RyanHolstien
RyanHolstien approved these changes Jun 14, 2024
View reviewed changes
Copy link
Collaborator

@RyanHolstien RyanHolstien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing blocking, just a couple of suggestions.

@david-leifker
feat(openapi): openapi v3 updates
2c31718 
* Added flag to HEAD endpoint to consider (or not) soft deleted entities
* GET operations will no longer return default key aspects (instead 404)
  * reflects whether the entity actually exists in the database
* better error messages on invalid urns
* refactor generic controller from models to servlet
@david-leifker david-leifker merged commit 34c1a95 into datahub-project:master Jun 14, 2024
40 of 41 checks passed
sleeperdeep pushed a commit to sleeperdeep/datahub that referenced this pull request Jun 25, 2024
@david-leifker @sleeperdeep
feat(openapi): openapi v3 updates (datahub-project#10710)
13fe0bb
yoonhyejin pushed a commit that referenced this pull request Jul 16, 2024
@david-leifker @yoonhyejin
feat(openapi): openapi v3 updates (#10710)
2c9b16a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RyanHolstien RyanHolstien RyanHolstien approved these changes

Assignees
No one assigned
Labels
devops PR or Issue related to DataHub backend & deployment product PR or Issue related to the DataHub UI/UX
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@david-leifker @RyanHolstien