Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ingest/dbt): support emitting only model performance #10714

Merged
merged 1 commit into from
Jun 18, 2024

Conversation

hsheth2
Copy link
Collaborator

@hsheth2 hsheth2 commented Jun 14, 2024

Previously we would require model/snapshot emission to be enabled for model performance to work. This removes that restriction.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

Previously we would require model/snapshot emission to be enabled for
model performance to work. This removes that restriction.
@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Jun 14, 2024
@hsheth2 hsheth2 merged commit f1e5a47 into master Jun 18, 2024
58 of 59 checks passed
@hsheth2 hsheth2 deleted the dbt-model-performance-standalone branch June 18, 2024 17:31
sleeperdeep pushed a commit to sleeperdeep/datahub that referenced this pull request Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants