Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ingest): add async batch mode to the rest sink #10733

Merged
merged 7 commits into from
Jun 25, 2024
Merged

feat(ingest): add async batch mode to the rest sink #10733

merged 7 commits into from
Jun 25, 2024

Conversation

hsheth2
Copy link
Collaborator

@hsheth2 hsheth2 commented Jun 18, 2024 •
edited
Loading

Stacked on #10718

  • Adds the BatchPartitionExecutor, and refactors some of the existing executor code into multiple files.
  • Adds a ASYNC_BATCH mode to the rest sink. This is default disabled for now, but will be turned on by default in the future.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@hsheth2 hsheth2 requested a review from treff7es June 18, 2024 04:56
@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Jun 18, 2024
asikowitz
asikowitz approved these changes Jun 25, 2024
View reviewed changes
Copy link
Collaborator

@asikowitz asikowitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable enough

metadata-ingestion/src/datahub/ingestion/sink/datahub_rest.py Outdated Show resolved Hide resolved
@hsheth2 hsheth2 added the merge-pending-ci A PR that has passed review and should be merged once CI is green. label Jun 25, 2024
@hsheth2 hsheth2 merged commit 724907b into master Jun 25, 2024
56 of 82 checks passed
@hsheth2 hsheth2 deleted the rest-async-batch branch June 25, 2024 22:49
yoonhyejin pushed a commit that referenced this pull request Jul 16, 2024
@hsheth2 @yoonhyejin
feat(ingest): add async batch mode to the rest sink (#10733)
122ac0b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asikowitz asikowitz asikowitz approved these changes

@treff7es treff7es Awaiting requested review from treff7es

Assignees
No one assigned
Labels
ingestion PR or Issue related to the ingestion of metadata merge-pending-ci A PR that has passed review and should be merged once CI is green.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hsheth2 @asikowitz