feat: allow task ownership as group #10742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
ingestion
fjmacagno
force-pushed
the
ownership-as-group
branch
from
b28f0b6
to
424a4dc
Compare
fjmacagno
force-pushed
the
ownership-as-group
branch
from
424a4dc
to
e4949dc
Compare
sleeperdeep
pushed a commit
to sleeperdeep/datahub
that referenced
this pull request
Jun 25, 2024
yoonhyejin
pushed a commit
that referenced
this pull request
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new configuration to the airflow plugin which allows captured ownership info to be applied as a corpgroup instead of a corpuser.
We need this because we generally have groups own pipelines and datasets, not users, but it is still nice to have a user be part of the owning group.
I had difficulty testing this locally, getting unit test failures before making any changes. My hope is that CI can confirm that i have made no breaking changes.
Checklist