Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(tags): Use TagUrn class when generating urn #10786

Merged
merged 5 commits into from
Jun 27, 2024
Merged

refactor(tags): Use TagUrn class when generating urn #10786

merged 5 commits into from
Jun 27, 2024

Conversation

eboneil
Copy link
Collaborator

@eboneil eboneil commented Jun 26, 2024

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@eboneil eboneil requested a review from hsheth2 June 26, 2024 21:05
@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Jun 26, 2024
@hsheth2 hsheth2 added the merge-pending-ci A PR that has passed review and should be merged once CI is green. label Jun 27, 2024
@eboneil eboneil enabled auto-merge (squash) June 27, 2024 17:58
@eboneil eboneil merged commit 1ae5bfc into master Jun 27, 2024
43 of 71 checks passed
@eboneil eboneil deleted the make_tag_urn_updates branch June 27, 2024 18:00
yoonhyejin pushed a commit that referenced this pull request Jul 16, 2024
@eboneil @hsheth2 @yoonhyejin
refactor(tags): Use TagUrn class when generating urn (#10786)
27c0f4d 
Co-authored-by: Harshal Sheth <hsheth2@gmail.com>
aviv-julienjehannet pushed a commit to aviv-julienjehannet/datahub that referenced this pull request Jul 17, 2024
@eboneil @hsheth2 @aviv-julienjehannet
refactor(tags): Use TagUrn class when generating urn (datahub-project…
38147f1 
…#10786)

Co-authored-by: Harshal Sheth <hsheth2@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hsheth2 hsheth2 hsheth2 approved these changes

Assignees
No one assigned
Labels
ingestion PR or Issue related to the ingestion of metadata merge-pending-ci A PR that has passed review and should be merged once CI is green.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eboneil @hsheth2