Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(airflow): Add comma parsing of owners to DataJobs #10903

Merged
merged 5 commits into from
Jul 17, 2024
Merged

fix(airflow): Add comma parsing of owners to DataJobs #10903

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b4da933
Add comma parsing of owners to datajobs
eboneil Jul 12, 2024
2081084
Update
eboneil Jul 12, 2024
eb567cc
One more
eboneil Jul 12, 2024
6d24978
Extract to helper function
eboneil Jul 17, 2024
d55cffb
Lint
eboneil Jul 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions ...a-ingestion-modules/airflow-plugin/src/datahub_airflow_plugin/client/airflow_generator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -282,10 +282,12 @@ def generate_datajob(
datajob.url = f"{base_url}/taskinstance/list/?flt1_dag_id_equals={datajob.flow_urn.flow_id}&_flt_3_task_id={task.task_id}"

if capture_owner and dag.owner:
if config and config.capture_ownership_as_group:
datajob.group_owners.add(dag.owner)
else:
datajob.owners.add(dag.owner)
if config.capture_ownership_info and dag.owner:
owners = [owner.strip() for owner in dag.owner.split(",")]
eboneil marked this conversation as resolved.
Show resolved Hide resolved
if config.capture_ownership_as_group:
data_job.group_owners.update(owners)
else:
data_job.owners.update(owners)
eboneil marked this conversation as resolved.
Show resolved Hide resolved

if capture_tags and dag.tags:
datajob.tags.update(dag.tags)
Expand Down
Loading