Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: fix learning center color scheme & typo #11043

Merged
merged 3 commits into from
Jul 31, 2024
Merged

docs: fix learning center color scheme & typo #11043

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9f20496
fix: fix broken imgs
yoonhyejin Jul 30, 2024
9ea3af0
fix: fix color scheme
yoonhyejin Jul 30, 2024
b43905c
fix: fix video link
yoonhyejin Jul 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion docs-website/src/learn/_components/LearnListPage/index.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,8 +58,9 @@ function BlogListPageContent(props) {
<strong>For: </strong>
{audiences.map((audience) => (
<button
className={`button button--secondary ${activeFilters.includes(audience) && "button--active"}`}
className={clsx(styles.button, "button button--secondary", { [styles.buttonActive]: activeFilters.includes(audience) })}
onClick={() => handleFilterToggle(audience)}
key={audience}
>
{audience}
</button>
Expand Down
8 changes: 7 additions & 1 deletion docs-website/src/learn/_components/LearnListPage/styles.module.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,4 +4,10 @@
align-items: center;
gap: 10px;
flex-wrap: wrap;
}

.buttonActive {
background-color: var(--ifm-color-primary);
border: 1px solid var(--ifm-color-primary);
color: #ffffff;
}
}
9 changes: 5 additions & 4 deletions docs-website/src/learn/business-metric.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,13 +72,14 @@ DataHub Cloud offers comprehensive features designed to tackle the challenges of
</p>

- **[Approval Flows](https://datahubproject.io/docs/managed-datahub/approval-workflows):** Structured workflows for approving changes to metric definitions, maintaining accuracy and reliability.
-

![Untitled](https://prod-files-secure.s3.us-west-2.amazonaws.com/f818df0d-1067-44ab-99e1-8cf45d930c01/33ebd070-32a1-4875-b220-c31373f5eedf/Untitled.png)
<p align="center">
<img width="80%" src="https://raw.githubusercontent.com/datahub-project/static-assets/main/imgs/blogs/data-freshness/lineage.png"/>
<br />
<i style={{color:"grey"}}>Lineage Tracking</i>
</p>
Comment on lines +77 to +80
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add alt text for the image.

The image should have alternate text to improve accessibility and comply with best practices.

<p align="center">
  <img width="80%" src="https://raw.githubusercontent.com/datahub-project/static-assets/main/imgs/blogs/data-freshness/lineage.png" alt="Lineage Tracking"/>
  <br />
  <i style={{color:"grey"}}>Lineage Tracking</i>
</p>
Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
<img width="80%" src="https://raw.githubusercontent.com/datahub-project/static-assets/main/imgs/blogs/data-freshness/lineage.png"/>
<br />
<i style={{color:"grey"}}>Lineage Tracking</i>
</p>
<img width="80%" src="https://raw.githubusercontent.com/datahub-project/static-assets/main/imgs/blogs/data-freshness/lineage.png" alt="Lineage Tracking"/>
<br />
<i style={{color:"grey"}}>Lineage Tracking</i>
</p>
Tools
Markdownlint

77-77: null
Images should have alternate text (alt text)

(MD045, no-alt-text)


- **[Lineage Tracking](https://datahubproject.io/docs/generated/lineage/lineage-feature-guide):** Tools to track the origin and transformations of metrics, ensuring they align with standardized definitions.
-
![Screenshot 2024-07-10 at 12.07.28 PM.png](https://prod-files-secure.s3.us-west-2.amazonaws.com/f818df0d-1067-44ab-99e1-8cf45d930c01/39503957-ad64-4d2d-a5b2-b140abfc1f6c/Screenshot_2024-07-10_at_12.07.28_PM.png)

By implementing these solutions, you can ensure that your business metrics are consistently defined and accurately used across all teams, supporting reliable analysis and decision-making.

Expand Down
Loading