Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(vulnerability): Insertion of sensitive information into log files #11088

Merged
merged 2 commits into from
Aug 3, 2024
Merged

chore(vulnerability): Insertion of sensitive information into log files #11088

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4975bc4
Insertion of sensitive information into log files
pinakipb2 Aug 3, 2024
a8351b7
Remove token from logging
pinakipb2 Aug 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .../src/main/java/com/linkedin/datahub/graphql/resolvers/auth/RevokeAccessTokenResolver.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ public CompletableFuture<Boolean> get(DataFetchingEnvironment environment) throw
final QueryContext context = environment.getContext();
final String tokenId = bindArgument(environment.getArgument("tokenId"), String.class);

log.info("User {} revoking access token {}", context.getActorUrn(), tokenId);
log.info("User {} revoking access token", context.getActorUrn());

if (isAuthorizedToRevokeToken(context, tokenId)) {
try {
Expand Down
8 changes: 4 additions & 4 deletions .../main/java/com/linkedin/datahub/graphql/resolvers/ingest/secret/DeleteSecretResolver.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,16 +23,16 @@ public DeleteSecretResolver(final EntityClient entityClient) {
public CompletableFuture<String> get(final DataFetchingEnvironment environment) throws Exception {
final QueryContext context = environment.getContext();
if (IngestionAuthUtils.canManageSecrets(context)) {
final String secretUrn = environment.getArgument("urn");
final Urn urn = Urn.createFromString(secretUrn);
final String inputUrn = environment.getArgument("urn");
final Urn urn = Urn.createFromString(inputUrn);
return GraphQLConcurrencyUtils.supplyAsync(
() -> {
try {
_entityClient.deleteEntity(context.getOperationContext(), urn);
return secretUrn;
return inputUrn;
} catch (Exception e) {
throw new RuntimeException(
String.format("Failed to perform delete against secret with urn %s", secretUrn),
String.format("Failed to perform delete against secret with urn %s", inputUrn),
e);
}
},
Expand Down
4 changes: 2 additions & 2 deletions metadata-utils/src/main/java/com/linkedin/metadata/utils/SearchUtil.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,10 +54,10 @@ public static List<FilterValue> convertToFilters(

public static FilterValue createFilterValue(String value, Long facetCount, Boolean isFilteredOn) {
// TODO(indy): test this
String[] aggregationTokens = value.split(AGGREGATION_SEPARATOR_CHAR);
String[] aggregations = value.split(AGGREGATION_SEPARATOR_CHAR);
FilterValue result =
new FilterValue().setValue(value).setFacetCount(facetCount).setFiltered(isFilteredOn);
String lastValue = aggregationTokens[aggregationTokens.length - 1];
String lastValue = aggregations[aggregations.length - 1];
if (lastValue.startsWith(URN_PREFIX)) {
try {
result.setEntity(Urn.createFromString(lastValue));
Expand Down
Loading