-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(spark-lineage): enable user with editor role to ingest dataProces… #11130
fix(spark-lineage): enable user with editor role to ingest dataProces… #11130
Conversation
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the WalkthroughThe recent update to the policies.json configuration file introduces a new term, "dataProcessInstance," to an existing array of recognized terms. This enhancement expands the system's capability to manage and utilize data process instances, thereby improving overall functionality and adaptability. Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- metadata-service/war/src/main/resources/boot/policies.json (1 hunks)
Additional comments not posted (1)
metadata-service/war/src/main/resources/boot/policies.json (1)
365-366
: Confirm the addition of "dataProcessInstance" to resource types.The addition of "dataProcessInstance" to the list of resource types for editors aligns with the PR objective. Ensure that this change is consistent across the system and supported by existing configurations.
Verification successful
Addition of "dataProcessInstance" is consistent and supported.
The addition of "dataProcessInstance" to the resource types in
policies.json
is consistent with existing configurations across the system. The entity type is already referenced in various parts of the codebase, indicating system support. No further changes are needed.
- References found in configuration files, Java classes, and test data confirm support for "dataProcessInstance".
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the system supports "dataProcessInstance" as a resource type. # Test: Search for configurations or code that reference "dataProcessInstance". rg --type json --type yaml --type java --type scala 'dataProcessInstance'Length of output: 103441
…sInstance Entity
Checklist
Summary by CodeRabbit