-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ingest): sort by last modified not working in the UI #11343
fix(ingest): sort by last modified not working in the UI #11343
Conversation
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
…b.com:sid-acryl/datahub-fork into ing-708-datasetProperties-patch-source-helper
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What happens if this is used with a source that supports patch_custom_properties
? Please add some tests for the scenario where the source produces MCP patches for dataset properties
e.g. redshift does this
if self.config.patch_custom_properties: |
metadata-ingestion/src/datahub/ingestion/api/auto_work_units/auto_dataset_properties_aspect.py
Outdated
Show resolved
Hide resolved
metadata-ingestion/src/datahub/ingestion/api/auto_work_units/auto_dataset_properties_aspect.py
Outdated
Show resolved
Hide resolved
metadata-ingestion/src/datahub/ingestion/api/auto_work_units/auto_dataset_properties_aspect.py
Outdated
Show resolved
Hide resolved
metadata-ingestion/src/datahub/ingestion/api/auto_work_units/auto_dataset_properties_aspect.py
Show resolved
Hide resolved
…b.com:sid-acryl/datahub-fork into ing-708-datasetProperties-patch-source-helper
In this case, the final work units include two patch units: one originating from the source and the other from auto_patch_last_modified. |
No description provided.