-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(ingest/mcp_diff): Fallback to overwriting file on more complicated diffs #11407
test(ingest/mcp_diff): Fallback to overwriting file on more complicated diffs #11407
Conversation
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
…ed diffs
3765f13
to
0d8b197
Compare
exclude_regex_paths=ignore_paths, | ||
ignore_order=True, | ||
custom_operators=[DeltaInfoOperator()], | ||
) | ||
if diff: | ||
aspect_changes[urn][aspect_name] = MCPAspectDiff.create(diff) | ||
if len(t1) > 1 and len(t2) > 1: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should this be an or
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was thinking I could handle this but you're right, I don't. Will make this change. Seems like I also have to regenerate goldens?
…ed diffs (datahub-project#11407) Co-authored-by: Harshal Sheth <hsheth2@gmail.com>
Checklist