-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(fabric): Add sandbox as a possible environment variable #11491
Conversation
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
@pedro93 I also thought about adding an environment for sandboxes in the past (but never created a PR for it, because the environments were deprecated for some time and we decided at some point that we don't want to include sandbox systems in our catalog)...maybe a comment from my side: As all other possible environments are somehow an abbreviation of something...what about "SBX" as an abbreviation for sandbox instead of "SANDBOX"? 😊 |
@Masterchen09 appreciate the feedback! I thought about the same thing but SBX is a little too much of an abbreviation. I fear it would confuse users. |
There are some environments which could already be a bit confusing like EI or RVW…to have it consistent SBX would probably be better, also as the environment is part of the URN, an abbreviation would be better. However I also understand your point that SBX could be confusing…it probably depends on whether you are a data engineer or an software developer…😊 |
Fully agree. Those are legacy as far as I'm aware from the Linkedin days.
Imagine if you're neither. Non technical folks just using DataHub to search would be even more confused when filtering by environment. |
…-project#11491) Co-authored-by: david-leifker <114954101+david-leifker@users.noreply.github.com>
Checklist