Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(cleanup): remove legacy bootstrap step #11494

Merged
merged 8 commits into from
Sep 30, 2024
Merged

chore(cleanup): remove legacy bootstrap step #11494

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
dcaddf7
chore(cleanup): remove legacy bootstrap step
david-leifker Sep 27, 2024
8450317
Merge branch 'master' into remove-gms-browsepathv2
david-leifker Sep 27, 2024
027ae65
enable stacktrace
david-leifker Sep 28, 2024
f88e796
Merge branch 'remove-gms-browsepathv2' of github.com:david-leifker/da…
david-leifker Sep 28, 2024
9dd8007
rerun-tasks
david-leifker Sep 28, 2024
ffae4d0
Merge branch 'master' into remove-gms-browsepathv2
david-leifker Sep 29, 2024
1fe77c6
test bypass build cache
david-leifker Sep 30, 2024
85f0699
restore gradle job
david-leifker Sep 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions ...e-consumer/src/main/java/com/linkedin/metadata/kafka/boot/MCLBootstrapManagerFactory.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@
import javax.annotation.Nonnull;
import org.springframework.beans.factory.annotation.Autowired;
import org.springframework.beans.factory.annotation.Qualifier;
import org.springframework.beans.factory.annotation.Value;
import org.springframework.context.annotation.Bean;
import org.springframework.context.annotation.Conditional;
import org.springframework.context.annotation.Configuration;
Expand All @@ -27,9 +26,6 @@ public class MCLBootstrapManagerFactory {

@Autowired private ConfigurationProvider _configurationProvider;

@Value("${bootstrap.upgradeDefaultBrowsePaths.enabled}")
private Boolean _upgradeDefaultBrowsePathsEnabled;

@Bean(name = "mclBootstrapManager")
@Scope("singleton")
@Nonnull
Expand Down
4 changes: 0 additions & 4 deletions ...e-consumer/src/main/java/com/linkedin/metadata/kafka/boot/MCPBootstrapManagerFactory.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@
import javax.annotation.Nonnull;
import org.springframework.beans.factory.annotation.Autowired;
import org.springframework.beans.factory.annotation.Qualifier;
import org.springframework.beans.factory.annotation.Value;
import org.springframework.context.annotation.Bean;
import org.springframework.context.annotation.Conditional;
import org.springframework.context.annotation.Configuration;
Expand All @@ -27,9 +26,6 @@ public class MCPBootstrapManagerFactory {

@Autowired private ConfigurationProvider _configurationProvider;

@Value("${bootstrap.upgradeDefaultBrowsePaths.enabled}")
private Boolean _upgradeDefaultBrowsePathsEnabled;

@Bean(name = "mcpBootstrapManager")
@Scope("singleton")
@Nonnull
Expand Down
6 changes: 0 additions & 6 deletions metadata-service/configuration/src/main/resources/application.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -343,12 +343,6 @@ incidents:
consumerGroupSuffix: ${INCIDENTS_HOOK_CONSUMER_GROUP_SUFFIX:}

bootstrap:
upgradeDefaultBrowsePaths:
enabled: ${UPGRADE_DEFAULT_BROWSE_PATHS_ENABLED:false} # enable to run the upgrade to migrate legacy default browse paths to new ones
backfillBrowsePathsV2:
enabled: ${BACKFILL_BROWSE_PATHS_V2:false} # Enables running the backfill of browsePathsV2 upgrade step. There are concerns about the load of this step so hiding it behind a flag. Deprecating in favor of running through SystemUpdate
reprocessDefaultBrowsePathsV2:
enabled: ${REPROCESS_DEFAULT_BROWSE_PATHS_V2:false} # reprocess V2 browse paths which were set to the default: {"path":[{"id":"Default"}]}
policies:
file: ${BOOTSTRAP_POLICIES_FILE:classpath:boot/policies.json}
# eg for local file
Expand Down
16 changes: 0 additions & 16 deletions ...factories/src/main/java/com/linkedin/metadata/boot/factories/BootstrapManagerFactory.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@
import com.linkedin.metadata.boot.BootstrapManager;
import com.linkedin.metadata.boot.BootstrapStep;
import com.linkedin.metadata.boot.dependencies.BootstrapDependency;
import com.linkedin.metadata.boot.steps.BackfillBrowsePathsV2Step;
import com.linkedin.metadata.boot.steps.IndexDataPlatformsStep;
import com.linkedin.metadata.boot.steps.IngestDataPlatformInstancesStep;
import com.linkedin.metadata.boot.steps.IngestDataPlatformsStep;
Expand All @@ -25,7 +24,6 @@
import com.linkedin.metadata.boot.steps.RestoreColumnLineageIndices;
import com.linkedin.metadata.boot.steps.RestoreDbtSiblingsIndices;
import com.linkedin.metadata.boot.steps.RestoreGlossaryIndices;
import com.linkedin.metadata.boot.steps.UpgradeDefaultBrowsePathsStep;
import com.linkedin.metadata.boot.steps.WaitForSystemUpdateStep;
import com.linkedin.metadata.entity.AspectMigrationsDao;
import com.linkedin.metadata.entity.EntityService;
Expand Down Expand Up @@ -89,12 +87,6 @@ public class BootstrapManagerFactory {

@Autowired private ConfigurationProvider _configurationProvider;

@Value("${bootstrap.upgradeDefaultBrowsePaths.enabled}")
private Boolean _upgradeDefaultBrowsePathsEnabled;

@Value("${bootstrap.backfillBrowsePathsV2.enabled}")
private Boolean _backfillBrowsePathsV2Enabled;

@Value("${bootstrap.policies.file}")
private Resource _policiesResource;

Expand Down Expand Up @@ -154,14 +146,6 @@ protected BootstrapManager createInstance(
ingestDataTypesStep,
ingestEntityTypesStep));

if (_upgradeDefaultBrowsePathsEnabled) {
finalSteps.add(new UpgradeDefaultBrowsePathsStep(_entityService));
}

if (_backfillBrowsePathsV2Enabled) {
finalSteps.add(new BackfillBrowsePathsV2Step(_entityService, _searchService));
}

return new BootstrapManager(finalSteps);
}
}
156 changes: 0 additions & 156 deletions ...e/factories/src/main/java/com/linkedin/metadata/boot/steps/BackfillBrowsePathsV2Step.java
View file
Open in desktop

This file was deleted.

145 changes: 0 additions & 145 deletions ...ctories/src/main/java/com/linkedin/metadata/boot/steps/UpgradeDefaultBrowsePathsStep.java
View file
Open in desktop

This file was deleted.

Loading
Loading