feat(ingest/bigquery): Add way to reference existing DataHub Tag from a bigquery label #11544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
ingestion
treff7es
force-pushed
the
bq_encoded_tag_ingestion
branch
from
6baabc6 to
f6ac8e7
Compare
fix linter error
hsheth2
approved these changes
Oct 8, 2024
| @@ -708,6 +722,8 @@ def gen_table_dataset_workunits( | |||
| tags_to_add.extend( | |||
| [ | |||
| make_tag_urn(f"""{k}:{v}""") | |||
| if not v.startswith(ENCODED_TAG_PREFIX) | |||
| else self.modified_base32decode(v) | |||
There was a problem hiding this comment.
let's pull this out into a make_tag_from_label(k, v) helper method, and ideally add some tests for that helper
sleeperdeep
pushed a commit
to sleeperdeep/datahub
that referenced
this pull request
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a way to reference existing DataHub Tag from a BigQuery label.
When we sync from DataHub to BigQuery, we encode the tags as modified base32 strings.
BiqQuery labels only support lowercase letters, international characters, numbers, or underscores.
So, we need to modify the base32 encoding to replace the padding character
=with_and convert it to lowercase.Checklist