fix(ingest/sac): handle descriptions which are None correctly #11572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
ingestion
Masterchen09
force-pushed
the
fix-sac-descriptions
branch
from
edde82a to
07aaa15
Compare
hsheth2
reviewed
Oct 9, 2024
| @@ -559,7 +561,7 @@ def get_sac_connection( | |||
|
|
|||
| retries = 3 | |||
| backoff_factor = 10 | |||
| status_forcelist = (500,) | |||
| status_forcelist = (400, 500, 503) | |||
There was a problem hiding this comment.
let's add a comment around this - similar to the PR description
| description=( | ||
| column["descriptionName"].strip() | ||
| if "descriptionName" in column | ||
| and column["descriptionName"] is not None |
There was a problem hiding this comment.
if column.get("descriptionName") is not None
|
@hsheth2 I have added a comment on why we have to retry requests with these HTTP status codes. 😊 |
hsheth2
approved these changes
Oct 11, 2024
hsheth2
changed the title
sleeperdeep
pushed a commit
to sleeperdeep/datahub
that referenced
this pull request
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is technically possible that the descriptions for Stories, Models and columns of Import Data models are None...this PR fixes the handling of such cases.
Additionally some more HTTP statuses will be retried (400 and 503) - unfortunately the Import Data API is a bit unstable and returns these HTTP status codes from time to time, although everything else is working.
FYI @hsheth2
Checklist