Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(docs-site) brought back announcement banner #11618

Merged
merged 1 commit into from
Oct 15, 2024
Merged

feat(docs-site) brought back announcement banner #11618

merged 1 commit into from
Oct 15, 2024

Conversation

jayacryl
Copy link
Collaborator

image

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@jayacryl jayacryl requested a review from yoonhyejin October 14, 2024 21:43
@github-actions github-actions bot added the community-contribution PR or Issue raised by member(s) of DataHub Community label Oct 14, 2024
yoonhyejin
yoonhyejin approved these changes Oct 14, 2024
View reviewed changes
Copy link
Collaborator

@yoonhyejin yoonhyejin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jayacryl jayacryl merged commit c834cdb into master Oct 15, 2024
38 checks passed
@jayacryl jayacryl deleted the jp--metadata-banner branch October 15, 2024 14:55
epatotski pushed a commit to acryldata/datahub that referenced this pull request Oct 22, 2024
@jayacryl @patotskiy
feat(docs-site) brought back announcement banner (datahub-project#11618)
00e6afd
sleeperdeep pushed a commit to sleeperdeep/datahub that referenced this pull request Dec 17, 2024
@jayacryl @sleeperdeep
feat(docs-site) brought back announcement banner (datahub-project#11618)
7dd08a3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yoonhyejin yoonhyejin yoonhyejin approved these changes

Assignees
No one assigned
Labels
community-contribution PR or Issue raised by member(s) of DataHub Community
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jayacryl @yoonhyejin