Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ingest): generate urn types for all entities #11676

Merged
merged 1 commit into from
Oct 22, 2024
Merged

feat(ingest): generate urn types for all entities #11676

merged 1 commit into from
Oct 22, 2024

Conversation

hsheth2
Copy link
Collaborator

@hsheth2 hsheth2 commented Oct 20, 2024

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Oct 20, 2024
@github-actions GitHub Actions
Copy link

Hello @hsheth2 😄

Thank you so much for opening a pull request!

Image
You can check out your contributor card and see all your past stats here!

shirshanka
shirshanka approved these changes Oct 20, 2024
View reviewed changes
Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Daniellundin048
Copy link

Daniellundin048 commented Oct 20, 2024 via email

@hsheth2 hsheth2 merged commit 7f6f18c into master Oct 22, 2024
72 of 75 checks passed
@hsheth2 hsheth2 deleted the data-platform-instance-urn branch October 22, 2024 18:49
sleeperdeep pushed a commit to sleeperdeep/datahub that referenced this pull request Dec 17, 2024
@hsheth2 @sleeperdeep
feat(ingest): generate urn types for all entities (datahub-project#11676
6e8df14 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shirshanka shirshanka shirshanka approved these changes

Assignees
No one assigned
Labels
ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hsheth2 @Daniellundin048 @shirshanka