Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

design: revamp navbar dropdown #11864

Merged
merged 14 commits into from
Jan 15, 2025
Merged

design: revamp navbar dropdown #11864

merged 14 commits into from
Jan 15, 2025

Conversation

yoonhyejin
Copy link
Collaborator

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Nov 15, 2024
Copy link

Hello @yoonhyejin 😄

Thank you so much for opening a pull request!

Image
You can check out your contributor card and see all your past stats here!

@yoonhyejin yoonhyejin changed the title Revamp navbar dropdown design: revamp navbar dropdown Nov 17, 2024
@datahub-cyborg datahub-cyborg bot added the needs-review Label for PRs that need review from a maintainer. label Nov 21, 2024
document.removeEventListener('touchstart', handleClickOutside);
document.removeEventListener('focusin', handleClickOutside);
};
}, [dropdownRef]);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should never change -see if you can have the linter just ignore the deps

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we delete these

@datahub-cyborg datahub-cyborg bot added pending-submitter-merge and removed needs-review Label for PRs that need review from a maintainer. labels Nov 22, 2024
Copy link

codecov bot commented Jan 15, 2025

❌ We are unable to process any of the uploaded JUnit XML files. Please ensure your files are in the right format.

@jayacryl jayacryl merged commit 3108b53 into master Jan 15, 2025
36 checks passed
@jayacryl jayacryl deleted the revamp-navbar-dropdown branch January 15, 2025 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ingestion PR or Issue related to the ingestion of metadata pending-submitter-merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants