fix(ui) Fix nesting logic in properties tab #12151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asikowitz
approved these changes
Dec 17, 2024
chriscollins3456
merged commit ef1c1df
into
datahub-project:master
65 of 69 checks passed
brock-acryl
pushed a commit
to brock-acryl/datahub
that referenced
this pull request
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most schema fields don't have their own urns yet in the database and structured properties are the first main aspect we're storing on them. This PR edits the
upsertStructuredPropertiesendpoint to allow users to add a property to a schema field urn that doesn't exist yet. This way users will be able to add/remove properties on schema fields even if they weren't minted by some other way yet (other than forms or API, there is no other way as far as I know).Checklist