Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tableau): prevents warning in case of site admin creator role #12175

Merged
merged 8 commits into from
Dec 19, 2024

Conversation

sgomezvillamor
Copy link
Contributor

@sgomezvillamor sgomezvillamor commented Dec 19, 2024

Fixes the following false positive warning, given that the user has Site Administrator Creator role

[2024-12-19 07:51:10,939] WARNING  {datahub.ingestion.source.tableau.tableau:649} - Insufficient Permissions: The user must have the `Site Administrator Explorer` role to perform metadata ingestion. => user-name=XXX, role=SiteAdministratorCreator, site_id=9f087e55-dc7b-42cb-YYYY
[2024-12-19 07:51:10,940] INFO     {datahub.ingestion.run.pipeline:297} - Source configured successfully.
[2024-12-19 07:51:10,940] INFO     {datahub.cli.ingest_cli:131} - Starting metadata ingestion
[2024-12-19 07:51:11,031] WARNING  {datahub.ingestion.source.tableau.tableau:649} - Insufficient Permissions: The user must have the `Site Administrator Explorer` role to perform metadata ingestion. => user-name=XXXXX, role=SiteAdministratorCreator, site_id=9f087e55-dc7b-42cb-YYYY

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Dec 19, 2024
@sgomezvillamor sgomezvillamor marked this pull request as ready for review December 19, 2024 09:09
@datahub-cyborg datahub-cyborg bot added the needs-review Label for PRs that need review from a maintainer. label Dec 19, 2024
@datahub-cyborg datahub-cyborg bot added pending-submitter-merge and removed needs-review Label for PRs that need review from a maintainer. labels Dec 19, 2024
@sgomezvillamor sgomezvillamor enabled auto-merge (squash) December 19, 2024 18:13
@sgomezvillamor sgomezvillamor merged commit acb76cd into master Dec 19, 2024
68 checks passed
@sgomezvillamor sgomezvillamor deleted the fix-tableau-permission-false-warning branch December 19, 2024 19:26
yoonhyejin pushed a commit to yoonhyejin/datahub-oss-forked that referenced this pull request Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ingestion PR or Issue related to the ingestion of metadata pending-submitter-merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants