Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(gms): Change names of charts in Analytics #12192

Merged
merged 1 commit into from
Dec 20, 2024
Merged

fix(gms): Change names of charts in Analytics #12192

merged 1 commit into from
Dec 20, 2024

Conversation

deepgarg-visa
Copy link
Contributor

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added product PR or Issue related to the DataHub UI/UX community-contribution PR or Issue raised by member(s) of DataHub Community labels Dec 20, 2024
@datahub-cyborg datahub-cyborg bot added the needs-review Label for PRs that need review from a maintainer. label Dec 20, 2024
david-leifker
david-leifker approved these changes Dec 20, 2024
View reviewed changes
Copy link
Collaborator

@david-leifker david-leifker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@datahub-cyborg datahub-cyborg bot removed the needs-review Label for PRs that need review from a maintainer. label Dec 20, 2024
@david-leifker david-leifker self-assigned this Dec 20, 2024
@datahub-cyborg datahub-cyborg bot added the merge-pending-ci A PR that has passed review and should be merged once CI is green. label Dec 20, 2024
@david-leifker david-leifker merged commit 1570139 into datahub-project:master Dec 20, 2024
96 of 101 checks passed
brock-acryl pushed a commit to brock-acryl/datahub that referenced this pull request Jan 30, 2025
@deepgarg-visa @chakru-r
fix(gms): Change names of charts in Analytics (datahub-project#12192)
08d6ff0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@david-leifker david-leifker david-leifker approved these changes

Assignees

@david-leifker david-leifker

Labels
community-contribution PR or Issue raised by member(s) of DataHub Community merge-pending-ci A PR that has passed review and should be merged once CI is green. product PR or Issue related to the DataHub UI/UX
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@deepgarg-visa @david-leifker