Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ingest): improve error reporting in emit_all #12309

Merged
merged 1 commit into from
Jan 10, 2025
Merged

fix(ingest): improve error reporting in emit_all #12309

merged 1 commit into from
Jan 10, 2025

Conversation

hsheth2
Copy link
Collaborator

@hsheth2 hsheth2 commented Jan 9, 2025

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Jan 9, 2025
@codecov Codecov
Copy link

codecov bot commented Jan 9, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...ta-ingestion/src/datahub/ingestion/graph/client.py 0.00% 1 Missing ⚠️
Files with missing lines Coverage Δ
...ta-ingestion/src/datahub/ingestion/graph/client.py 29.09% <0.00%> (-0.06%) ⬇️

... and 203 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 210e2c1...d07919a. Read the comment docs.

@datahub-cyborg datahub-cyborg bot added the needs-review Label for PRs that need review from a maintainer. label Jan 9, 2025
sgomezvillamor
sgomezvillamor approved these changes Jan 10, 2025
View reviewed changes
metadata-ingestion/src/datahub/ingestion/graph/client.py
@@ -248,9 +248,11 @@ def make_rest_sink(
with DatahubRestSink(PipelineContext(run_id=run_id), sink_config) as sink:
yield sink
if sink.report.failures:
logger.error(
f"Failed to emit {len(sink.report.failures)} records\n{sink.report.as_string()}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering if sink.report.as_string() might be too verbose.

The report will be printed out once the pipeline finishes, regardless of success, right? If so, printing it here may be redundant.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is only printed if the sink had any failures

it is somewhat verbose, but it's definitely better than not printing anything

@datahub-cyborg datahub-cyborg bot added pending-submitter-merge and removed needs-review Label for PRs that need review from a maintainer. labels Jan 10, 2025
@hsheth2 hsheth2 merged commit cf35dcc into master Jan 10, 2025
222 of 251 checks passed
@hsheth2 hsheth2 deleted the emit-all-errors branch January 10, 2025 17:49
llance pushed a commit to llance/datahub that referenced this pull request Jan 13, 2025
@hsheth2 @llance
fix(ingest): improve error reporting in emit_all (datahub-project#1…
0c6b254 
…2309)
llance pushed a commit to llance/datahub that referenced this pull request Jan 13, 2025
@hsheth2 @llance
fix(ingest): improve error reporting in emit_all (datahub-project#1…
dce91c1 
…2309)
brock-acryl pushed a commit to brock-acryl/datahub that referenced this pull request Jan 30, 2025
@hsheth2 @chakru-r
fix(ingest): improve error reporting in emit_all (datahub-project#1…
e64baec 
…2309)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgomezvillamor sgomezvillamor sgomezvillamor approved these changes

Assignees
No one assigned
Labels
ingestion PR or Issue related to the ingestion of metadata pending-submitter-merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hsheth2 @sgomezvillamor