Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(openapi): precondition exceptions return 412 #12552

Conversation

david-leifker
Copy link
Collaborator

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added product PR or Issue related to the DataHub UI/UX devops PR or Issue related to DataHub backend & deployment smoke_test Contains changes related to smoke tests labels Feb 4, 2025
@datahub-cyborg datahub-cyborg bot added the needs-review Label for PRs that need review from a maintainer. label Feb 4, 2025
Copy link

codecov bot commented Feb 4, 2025

Codecov Report

Attention: Patch coverage is 56.09756% with 18 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...enapi/config/GlobalControllerExceptionHandler.java 0.00% 16 Missing ⚠️
.../plugins/validation/AspectValidationException.java 50.00% 1 Missing and 1 partial ⚠️

❌ Your patch status has failed because the patch coverage (53.84%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage.

Files with missing lines Coverage Δ
...gins/validation/ValidationExceptionCollection.java 100.00% <100.00%> (+53.57%) ⬆️
...a/aspect/plugins/validation/ValidationSubType.java 100.00% <100.00%> (ø)
...om/linkedin/metadata/entity/EntityServiceImpl.java 80.19% <100.00%> (+0.01%) ⬆️
.../plugins/validation/AspectValidationException.java 75.00% <50.00%> (-5.00%) ⬇️
...enapi/config/GlobalControllerExceptionHandler.java 0.00% <0.00%> (ø)

... and 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a4f64fd...b8de5ad. Read the comment docs.

@datahub-cyborg datahub-cyborg bot added pending-submitter-merge and removed needs-review Label for PRs that need review from a maintainer. labels Feb 5, 2025
@david-leifker david-leifker merged commit 7f88710 into datahub-project:master Feb 5, 2025
201 of 225 checks passed
shirshanka pushed a commit to shirshanka/datahub that referenced this pull request Mar 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devops PR or Issue related to DataHub backend & deployment pending-submitter-merge product PR or Issue related to the DataHub UI/UX smoke_test Contains changes related to smoke tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants