feat(sdk): add support for institutional memory links #12770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
ingestion
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
📢 Thoughts on this report? Let us know! |
datahub-cyborg
bot
added
the
needs-review
Comment on lines
+511
to
+513
| # Internally the aspect is called institutionalMemory, and so much of the code | ||
| # uses that name. However, the public-facing API is called "links", since | ||
| # that's what we call these in the UI. |
There was a problem hiding this comment.
In GraphQL and OpenAPI we use InstitutionalMemory, should we align here with the UI or other APIs? 🤔
There was a problem hiding this comment.
Because this sdk is for end users, we should align with the UI
| @@ -49,6 +50,8 @@ | |||
|
|
|||
| ActorUrn: TypeAlias = Union[CorpUserUrn, CorpGroupUrn] | |||
|
|
|||
| _DEFAULT_ACTOR_URN = CorpUserUrn("__ingestion").urn() | |||
There was a problem hiding this comment.
not in the scope of this PR but, should this "ingestion actor" configurable?
There was a problem hiding this comment.
maybe - we don't show it anywhere in the UI, so it's not really particularly relevant. it's here mainly because a couple fields require it for backwards compat
datahub-cyborg
bot
added
pending-submitter-merge
and removed
needs-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist