Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: datasets client to extend browsable client #1939

Merged
merged 1 commit into from
Oct 16, 2020
Merged

refactor: datasets client to extend browsable client #1939

merged 1 commit into from
Oct 16, 2020

Conversation

jywadhwani
Copy link
Contributor

Also deprecating an obsolete file DatasetUtils.java

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

@mars-lan mars-lan added the hacktoberfest-accepted Acceptance for hacktoberfest https://hacktoberfest.com/participation/ label Oct 14, 2020
keremsahin1
keremsahin1 reviewed Oct 15, 2020
View reviewed changes
Copy link
Contributor

@keremsahin1 keremsahin1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also make sure to test this E2E

@jywadhwani
Copy link
Contributor Author

@keremsahin1 tested this E2E - search, browse and autocomplete work as expected for datasets.

@jywadhwani jywadhwani merged commit 39cab54 into datahub-project:master Oct 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keremsahin1 keremsahin1 keremsahin1 approved these changes

Assignees
No one assigned
Labels
hacktoberfest-accepted Acceptance for hacktoberfest https://hacktoberfest.com/participation/
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jywadhwani @keremsahin1 @mars-lan