Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(User Search): Fixing CorpUsers Search Bug #2073

Merged
merged 1 commit into from
Jan 29, 2021

Conversation

jjoyce0510
Copy link
Collaborator

@jjoyce0510 jjoyce0510 commented Jan 29, 2021

Fixing the issue where ingested CorpUsers are not appearing on the frontend. This is because the CorpUsersInfo search index is not being updated, because the index builder is not registered by default.

This is the PR where the issue was introduced: #2024

https://datahubspace.slack.com/archives/CUMUWQU66/p1611759465003400

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shirshanka
Copy link
Contributor

Thanks @jjoyce0510, will merge after CI checks pass.

Copy link
Contributor

@nagarjunakanamarlapudi nagarjunakanamarlapudi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shirshanka shirshanka merged commit 9e66aa0 into datahub-project:master Jan 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants