Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: renaming graphql_frontend rfc directory with pull request number #2182

Merged
merged 1 commit into from
Mar 9, 2021
Merged

chore: renaming graphql_frontend rfc directory with pull request number #2182

merged 1 commit into from
Mar 9, 2021

Conversation

shirshanka
Copy link
Contributor

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

jjoyce0510
jjoyce0510 approved these changes Mar 8, 2021
View reviewed changes
Copy link
Collaborator

@jjoyce0510 jjoyce0510 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jjoyce0510
Copy link
Collaborator

Hey one thing -- do we need to update references inside of datahub-docs-website/sidebars.js to point to the new docs? See: https://github.com/linkedin/datahub/blob/master/docs-website/sidebars.js#L115

@shirshanka shirshanka requested a review from woodyzhou March 9, 2021 02:40
@hsheth2
Copy link
Collaborator

hsheth2 commented Mar 9, 2021

@jjoyce0510 as of #2191, we don't need to update sidebars.js for RFCs 😄

woodyzhou
woodyzhou approved these changes Mar 9, 2021
View reviewed changes
Copy link
Contributor

@woodyzhou woodyzhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shirshanka shirshanka merged commit c2168e9 into datahub-project:master Mar 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@woodyzhou woodyzhou woodyzhou approved these changes

@jjoyce0510 jjoyce0510 jjoyce0510 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shirshanka @jjoyce0510 @hsheth2 @woodyzhou