refactor(React / Ember): React as the default UI #2252
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope
This change affects folks using both React + Ember app.
Changes
This change swaps makes React the default UI and includes both code & documentation changes necessary to do so. Specific changes include
docker-compose.yml
, remove legacydatahub-frontend
container. This means quickstart will launch with React app on localhost:9002 by default.docker-compose.ember.yml
, an extension compose file containing the legacy ember container.quickstart-ember.sh
, removesquickstart-react.sh
.Validation
Locally built
datahub-frontend-ember
anddatahub-frontend-react
services.Checklist