-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ingest): Add option to change name of database for postgres #2898
feat(ingest): Add option to change name of database for postgres #2898
Conversation
ce1e6e0
to
300db20
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
In the future, we'll probably want a more principled/general way of handling this sort of modification, and ideally would have transformers to handle this. As such, I'm thinking about these changes are more of a stopgap measure.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggest we name the field as database_alias
instead of database_identifier
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@shirshanka I am not sure where to add the missing dependency for the test. Can you please suggest which file needs this change? |
@aseembansal-gogo : this would be in setup.py Add
|
Checklist