refactor(test): Refactor GraphService tests #2944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM, @gabe-lyons to take a look. |
|
@shirshanka @gabe-lyons thanks for looking into this. Can this go forward? I have more contributions that base on this. |
gabe-lyons
approved these changes
Aug 2, 2021
shirshanka
approved these changes
Aug 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactors
ElasticSearchGraphServiceTest.javaandNeo4jGraphServiceTest.javato reduce code duplication and establish a set of tests shared across thoseGraphServiceimplementations. This ensures all implementations are tested in the same way, while individual implementations can still add implementation specific tests.Adding another
GraphServiceimplementation can then easily be tested at the same level as existing implementations.