fix(ingest): patch lookml types and refactor ingestion sources layout #2950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hsheth2
reviewed
Jul 23, 2021
metadata-ingestion/setup.py
Outdated
| "mssql = datahub.ingestion.source.mssql:SQLServerSource", | ||
| "mysql = datahub.ingestion.source.mysql:MySQLSource", | ||
| "mssql = datahub.ingestion.source.sql.mssql:SQLServerSource", | ||
| "mysql = datahub.ingestion.source.sql.mysql:MySQLSource", | ||
| "oracle = datahub.ingestion.source.oracle:OracleSource", |
There was a problem hiding this comment.
seems like you missed hive, oracle, and the generic sqlalchemy source
| @@ -478,6 +483,8 @@ def _get_upstream_lineage(self, looker_view: LookerView) -> UpstreamLineage: | |||
|
|
|||
| def _get_field_type(self, native_type: str) -> SchemaFieldDataType: | |||
| field_type_mapping = { | |||
| **POSTGRES_TYPES_MAP, | |||
There was a problem hiding this comment.
would be good to move this up to the top-level of the file (only initialize the dict once + allows dynamic modification if needed)
| if native_type in field_type_mapping: | ||
| type_class = field_type_mapping[native_type] | ||
| else: | ||
| type_class = field_type_mapping.get(native_type) |
There was a problem hiding this comment.
let's make sure this is comprehensive
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist