Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ingest): import type stubs only for testing #3032

Merged
merged 2 commits into from
Aug 4, 2021
Merged

fix(ingest): import type stubs only for testing #3032

merged 2 commits into from
Aug 4, 2021

Conversation

kevinhu
Copy link
Contributor

@kevinhu kevinhu commented Aug 4, 2021 •
edited
Loading

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

shirshanka
shirshanka approved these changes Aug 4, 2021
View reviewed changes
Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kevinhu kevinhu marked this pull request as ready for review August 4, 2021 19:36
@shirshanka shirshanka merged commit 3d06116 into datahub-project:master Aug 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shirshanka shirshanka shirshanka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kevinhu @shirshanka