(feat)(Business Glossary) added field level glossary terms #3048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saxo-lalrishav
changed the title
gabe-lyons
reviewed
Aug 6, 2021
|
@saxo-lalrishav does the use of OR to combine the two queries into one make sense on your side? |
|
Yes, that looks good, thanks for the reference. |
gabe-lyons
reviewed
Aug 12, 2021
| filteredSearchResult[type] = entitySearchResult[type].data?.search?.searchResults; | ||
| filteredSearchResult[type] = entities; |
There was a problem hiding this comment.
is this change intentional?
There was a problem hiding this comment.
yes, just wanted to reuse the variable
hope it will not result in any issue,
There was a problem hiding this comment.
ah i see now- makes sense!
rahulbsw
pushed a commit
to rahulbsw/datahub
that referenced
this pull request
Sep 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist