Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sso): Just-In-Time User & Group Provisioning on SSO Login (oidc) #3082

Merged
merged 22 commits into from
Aug 20, 2021

Conversation

jjoyce0510
Copy link
Collaborator

@jjoyce0510 jjoyce0510 commented Aug 12, 2021

We're really excited about this one! This PR is a part of an initiative to improve the User & Group onboarding experience inside of DataHub.

Status
ready

Changes
This PR introduces just-in-time provisioning of users and groups in DataHub. This means that users and optionally groups (if they can be extracted) are created for a user at login time if they do not already exist. Note that in the future we'd like support merging of existing information with new information provided by an IdP at login, but that will not appear in this iteration.

Going forward, this behavior will be the default for deployments with OIDC enabled. However, this behavior can be disabled altogether (for example if you are batch ingesting your users). For information on how to customize this behavior for your deployment, see the doc configure-oidc-react.md doc.

In addition to adding provisioning, I've also refactored the SSO related code significantly to set us up for a future where multiple SSO protocols are supported: OIDC, SAML 2.0 & beyond. This includes the addition of the following components in the datahub frontend server:

  • SsoManager: Responsible for providing information about the currently active SSO configurations.
  • SsoController: Responsible for handling the indirect identity provider callback to DataHub, including routing to protocol-specific handlers like the new OidcCallbackLogic class.
  • SsoProvider: A thin wrapper around the Pac4j Client object as well as a DataHub-specific set of SSO configurations (e.g. OidcConfigs).

Manually validated all configurations against a deployment of Okta.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

@jjoyce0510 jjoyce0510 force-pushed the JITUserGroupProvisioning branch from 64bfd22 to 846dc6f Compare August 20, 2021 05:11
Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shirshanka shirshanka merged commit 81eb4f1 into datahub-project:master Aug 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants