Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ingest): Add custom browse paths for kafka sources and remove browse lowercase filter #3113

Merged

Conversation

dexter-mh-lee
Copy link
Contributor

Add custom browse paths for kafka sources, so it does not separate on dots.

Also removed the lowercase filter for browse, and added a way to reindex all indices on settings change.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Will wait for CI to pass.

@shirshanka shirshanka merged commit db3784b into datahub-project:master Aug 19, 2021
gabe-lyons pushed a commit to gabe-lyons/datahub that referenced this pull request Aug 31, 2021
rahulbsw pushed a commit to rahulbsw/datahub that referenced this pull request Sep 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants