Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(search): Add searchable annotation to maps #3136

Merged
merged 15 commits into from
Sep 8, 2021

Conversation

dexter-mh-lee
Copy link
Contributor

We want to index the key/values in the custom properties, but if we index it as an object type, es will try to index each nested field separately and may increase the size of the index if any sources ingests a huge properties bag. Instead, we index it as a list with "key=value" as element. This allows us to search for specific fields with the "customProperties:key=value" query.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shirshanka shirshanka merged commit e30d723 into datahub-project:master Sep 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants