New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(404): Fix 404 Exit Error. #3189

Merged

shirshanka merged 2 commits into datahub-project:master from jjoyce0510:404fixes

Sep 3, 2021

Collaborator

jjoyce0510 commented Sep 3, 2021 •

edited

Loading

404 causes process to exit for previous upgrades. Need to figure out how to make backwards incompatibility checks more robust.

Also removing a cheeky log line John added during a period of great dev frustration

Checklist

The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
Links to related issues (if applicable)
Tests for the changes have been added/updated (if applicable)
Docs related to the changes have been added/updated (if applicable)

jjoyce0510 added 2 commits

September 2, 2021 21:05


          Fixing 404 detection bug

d01a9aa


          remove unused import

7551c89

shirshanka approved these changes

View reviewed changes

shirshanka merged commit d9380ee into datahub-project:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet