Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the datahub-frontend.graphql #3193

Merged
merged 1 commit into from
Sep 3, 2021

Conversation

abdvl
Copy link
Contributor

@abdvl abdvl commented Sep 3, 2021

Remove the datahub-frontend.graphql from the mock server, the schema definition is already covered in the gms.graphql. And the original file ('../../../datahub-frontend/conf/datahub-frontend.graphql') is been removed.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

Remove the `datahub-frontend.graphql` from the mock server, the schema definition is already covered in the `gms.graphql`.
Copy link
Collaborator

@jjoyce0510 jjoyce0510 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this!

Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shirshanka shirshanka merged commit 13d6280 into datahub-project:master Sep 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants