Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(access control): Adding "authorizedActors" method to AuthorizationManager #3197

Merged

Conversation

jjoyce0510
Copy link
Collaborator

2 changes:

  1. Fixing issue where "ALLOW_ALL" mode was not being honored (misconfigured test)
  2. Adding an "authorizedActors" method to AuthorizationManager to allow asking the question: "Who is authorized for this privilege against this resource?"
  3. Introducing a thin wrapper called OwnershipClient to make fetching the standard Ownership aspect easier.
  4. Unit tests

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shirshanka shirshanka merged commit 5322638 into datahub-project:master Sep 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants