feat(foreign keys): add foreign key models #3275
Conversation
…s' into AddingForeignKeyPrimaryKeyModels
…s' into AddingForeignKeyPrimaryKeyModels
…s' into AddingForeignKeyPrimaryKeyModels
metadata-models/src/main/pegasus/com/linkedin/metadata/aspect/SchemaFieldAspect.pdl
Show resolved
Hide resolved
metadata-models/src/main/pegasus/com/linkedin/metadata/snapshot/DatasetSnapshot.pdl
Show resolved
Hide resolved
metadata-models/src/main/pegasus/com/linkedin/metadata/snapshot/SchemaFieldSnapshot.pdl
Show resolved
Hide resolved
metadata-models/src/main/pegasus/com/linkedin/metadata/snapshot/Snapshot.pdl
Show resolved
Hide resolved
| import com.linkedin.metadata.key.SchemaFieldKey | ||
|
|
||
| /** | ||
| * A union of all supported metadata aspects for a Dataset |
| import com.linkedin.common.Urn | ||
|
|
||
| /** | ||
| * Key for a SchemaField |
There was a problem hiding this comment.
Should we call these models DatasetSchemaField?
There was a problem hiding this comment.
hmm.. actually updating this to be container rather than dataset so we have the flexibility to add schema fields to other things
| } | ||
| dataset: Urn | ||
|
|
||
| /** |
There was a problem hiding this comment.
Field path spec is going to get much more important :)
| "entityTypes": [ "schemaField" ] | ||
| } | ||
| } | ||
| foreignFields: array[Urn] |
There was a problem hiding this comment.
What's a use case with multiple foreign key fields?
There was a problem hiding this comment.
(a,b,c) in Table 1 are compound keys pointing to (d,e,f) in Table 2
| "name": "ForeignKeyToDataset", | ||
| "entityTypes": [ "dataset" ] | ||
| } | ||
| foreignDataset: Urn |
There was a problem hiding this comment.
Consider placing this at the top of this model
There was a problem hiding this comment.
I think it makes sense where it is- this is just for sake of easy reference.
| name: string | ||
|
|
||
| /** | ||
| * Fields the constraint maps to on the foreign dataset |
There was a problem hiding this comment.
maybe a note that these are expected to be schema field urns... and what that structure looks like?
There was a problem hiding this comment.
that is already annotated in the entityTypes property below :)
gabe-lyons
force-pushed
the
AddingForeignKeyPrimaryKeyModels
branch
from
4abbbee to
b4acd57
Compare
| @Searchable = { | ||
| "fieldType": "URN", | ||
| } | ||
| container: Urn |
)" This reverts commit 6d6acff.
Adding the modeling for foreign keys + schema fields
Checklist