Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ingest) optional custom headers REST emitter. #3290

Merged
merged 2 commits into from
Sep 23, 2021
Merged

feat(ingest) optional custom headers REST emitter. #3290

merged 2 commits into from
Sep 23, 2021

Conversation

adriaanslechten
Copy link
Contributor

PR to resolve issue #3289

Adds an optional k,v extra_headers part to the REST emitter in the metadata ingestion lib.
Also updated the docs a bit.

Checklist

  • [v] The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • [V] Links to related issues (if applicable)
  • [V] Tests for the changes have been added/updated (if applicable)
  • [V] Docs related to the changes have been added/updated (if applicable)

jjoyce0510
jjoyce0510 approved these changes Sep 23, 2021
View reviewed changes
Copy link
Collaborator

@jjoyce0510 jjoyce0510 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great to me

shirshanka
shirshanka approved these changes Sep 23, 2021
View reviewed changes
Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks :)

@shirshanka shirshanka merged commit 185f7e2 into datahub-project:master Sep 23, 2021
xdl pushed a commit to G-Research/datahub that referenced this pull request Oct 4, 2021
@adriaanslechten @adriaanslechtenklarna @xdl
feat(ingest): optional custom headers REST emitter (datahub-project#3290
bb6cae2 
)

Co-authored-by: Adriaan Slechten <adriaan.slechten@klarna.com>
xdl added a commit to G-Research/datahub that referenced this pull request Oct 5, 2021
@xdl
Revert "feat(ingest): optional custom headers REST emitter (datahub-p…
43b7c01 
…roject#3290)"

This reverts commit bb6cae2.
jgiannuzzi pushed a commit to G-Research/datahub that referenced this pull request Oct 6, 2021
@adriaanslechten @adriaanslechtenklarna @jgiannuzzi
feat(ingest): optional custom headers REST emitter (datahub-project#3290
f6d132f 
)

Co-authored-by: Adriaan Slechten <adriaan.slechten@klarna.com>
swaroopjagadish pushed a commit to swaroopjagadish/datahub that referenced this pull request Oct 7, 2021
@adriaanslechten @adriaanslechtenklarna @swaroopjagadish
feat(ingest): optional custom headers REST emitter (datahub-project#3290
760e73a 
)

Co-authored-by: Adriaan Slechten <adriaan.slechten@klarna.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shirshanka shirshanka shirshanka approved these changes

@jjoyce0510 jjoyce0510 jjoyce0510 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@adriaanslechten @shirshanka @jjoyce0510 @adriaanslechtenklarna