Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(ingestion): fix airflow 1 deps for tox #4083

Merged
merged 8 commits into from
Feb 17, 2022

Conversation

hsheth2
Copy link
Collaborator

@hsheth2 hsheth2 commented Feb 8, 2022

Due to some backtracking issues with the pip dependency resolver, we disabled the airflow 1 tests in CI. This PR provides a fix to that issue and reverts the temporary hack implemented in #4055.

Tested locally using tox -e py3-airflow1 --verbose.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

@github-actions
Copy link

github-actions bot commented Feb 8, 2022

Unit Test Results (build & test)

  70 files  ±0    70 suites  ±0   10m 26s ⏱️ - 4m 20s
609 tests ±0  550 ✔️ ±0  59 💤 ±0  0 ±0 

Results for commit 6a45659. ± Comparison against base commit ae6f5a8.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Feb 8, 2022

Unit Test Results (metadata ingestion)

       5 files         5 suites   38m 6s ⏱️
   313 tests    313 ✔️   0 💤 0
1 439 runs  1 401 ✔️ 38 💤 0

Results for commit 6a45659.

♻️ This comment has been updated with latest results.

Only 1.26+ have the allowed_methods kwarg, which we use for retry configuration.
@hsheth2 hsheth2 marked this pull request as ready for review February 11, 2022 19:15
Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shirshanka shirshanka merged commit 75d2ec2 into datahub-project:master Feb 17, 2022
hevandro-veiga pushed a commit to hevandro-veiga/datahub that referenced this pull request Feb 18, 2022
@hsheth2 hsheth2 deleted the airflow1-deps branch May 11, 2022 03:06
maggiehays pushed a commit to maggiehays/datahub that referenced this pull request Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants