Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(glossary terms): fix add glossary term flow #4106

Merged

Conversation

gabe-lyons
Copy link
Contributor

Introduced in: #4072

Fortunately, this was caught by our newly introduced smoke test for terms.

Also adds some waiting to add tag smoke test to prevent flaking

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

@github-actions
Copy link

Unit Test Results (build & test)

  69 files  ±0    69 suites  ±0   9m 21s ⏱️ - 1m 0s
604 tests ±0  545 ✔️ +1  59 💤 ±0  0  - 1 

Results for commit 8e04c33. ± Comparison against base commit 2d7452d.

Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shirshanka shirshanka merged commit 582ba47 into datahub-project:master Feb 10, 2022
ne1r0n pushed a commit to ne1r0n/datahub that referenced this pull request Feb 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants