bug(glossaryTermLabels): fix glossary term labels missing and add cypress test #4171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjoyce0510
reviewed
Feb 17, 2022
| @@ -62,7 +62,7 @@ export const SearchFilterLabel = ({ aggregation, field }: Props) => { | |||
| <> | |||
| <Tag closable={false}> | |||
| <BookOutlined style={{ marginRight: '3%' }} /> | |||
| {term.name} | |||
| {term.properties?.name} | |||
There was a problem hiding this comment.
Let's use entityRegistry.getDisplayName(EntityType.GlossaryTerm, term)
hevandro-veiga
pushed a commit
to hevandro-veiga/datahub
that referenced
this pull request
Feb 18, 2022
…ress test (datahub-project#4171) * bug(glossaryTermLabels): fix glossary term labels missing and add cypress test * review comment * fix cypress test Co-authored-by: Ryan Holstien <ryan@acryl.io>
maggiehays
pushed a commit
to maggiehays/datahub
that referenced
this pull request
Aug 1, 2022
…ress test (datahub-project#4171) * bug(glossaryTermLabels): fix glossary term labels missing and add cypress test * review comment * fix cypress test Co-authored-by: Ryan Holstien <ryan@acryl.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist