Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(workflow) Fix model generate workflow #4352

Merged
merged 1 commit into from
Mar 8, 2022
Merged

fix(workflow) Fix model generate workflow #4352

merged 1 commit into from
Mar 8, 2022

Conversation

dexter-mh-lee
Copy link
Contributor

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

@github-actions
Copy link

github-actions bot commented Mar 8, 2022

Unit Test Results (build & test)

  76 files  +1    76 suites  +1   18m 35s ⏱️ - 3m 29s
629 tests +6  570 ✔️ +7  59 💤 ±0  0 ❌  - 1 

Results for commit a9badca. ± Comparison against base commit ef31b0e.

shirshanka
shirshanka approved these changes Mar 8, 2022
View reviewed changes
Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shirshanka shirshanka merged commit 93acefd into datahub-project:master Mar 8, 2022
@dexter-mh-lee dexter-mh-lee deleted the dl--fix-model-generate-workflow branch April 4, 2022 23:47
maggiehays pushed a commit to maggiehays/datahub that referenced this pull request Aug 1, 2022
@maggiehays
fix(ci): fix model generation workflow (datahub-project#4352)
f1532e3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shirshanka shirshanka shirshanka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dexter-mh-lee @shirshanka