Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ingestion): Invoke SqlLineageSQLParser's implementation in a separate process #4391

Merged

Conversation

rslanka
Copy link
Contributor

@rslanka rslanka commented Mar 11, 2022

This change wraps the invocation of the SqlLineageSQLParser's implementation in a separate process to eliminate memory leaks originating from sqllineage module from affecting the datahub ingest cli for the lookml and redash connectors.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

@github-actions
Copy link

github-actions bot commented Mar 11, 2022

Unit Test Results (build & test)

  92 files  ±0    92 suites  ±0   11m 41s ⏱️ - 8m 25s
672 tests ±0  613 ✔️ ±0  59 💤 ±0  0 ±0 

Results for commit 0ed2d96. ± Comparison against base commit 1198123.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Mar 11, 2022

Unit Test Results (metadata ingestion)

       5 files  ±0         5 suites  ±0   45m 49s ⏱️ - 1m 21s
   362 tests ±0     362 ✔️ ±0    0 💤 ±0  0 ±0 
1 657 runs  ±0  1 626 ✔️ ±0  31 💤 ±0  0 ±0 

Results for commit 0ed2d96. ± Comparison against base commit 1198123.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shirshanka shirshanka merged commit 50ef658 into datahub-project:master Mar 15, 2022
maggiehays pushed a commit to maggiehays/datahub that referenced this pull request Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants