Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: telemetry failure should not cause CLI failure #4406

Merged
merged 4 commits into from
Mar 14, 2022
Merged

fix: telemetry failure should not cause CLI failure #4406

merged 4 commits into from
Mar 14, 2022

Conversation

anshbansal
Copy link
Collaborator

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

@github-actions
Copy link

github-actions bot commented Mar 14, 2022 •
edited
Loading

Unit Test Results (metadata ingestion)

       5 files  ±0         5 suites  ±0   44m 38s ⏱️ +58s
   362 tests ±0     362 ✔️ ±0    0 💤 ±0  0 ❌ ±0 
1 657 runs  ±0  1 626 ✔️ ±0  31 💤 ±0  0 ❌ ±0 

Results for commit dcf6c02. ± Comparison against base commit f0230b0.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Mar 14, 2022 •
edited
Loading

Unit Test Results (build & test)

  92 files  ±0    92 suites  ±0   21m 0s ⏱️ -10s
672 tests ±0  613 ✔️ +2  59 💤 ±0  0 ❌  - 2 

Results for commit dcf6c02. ± Comparison against base commit f0230b0.

♻️ This comment has been updated with latest results.

@shirshanka shirshanka merged commit 1198123 into datahub-project:master Mar 14, 2022
@anshbansal anshbansal deleted the fix-telemetry branch March 15, 2022 05:28
maggiehays pushed a commit to maggiehays/datahub that referenced this pull request Aug 1, 2022
@anshbansal @maggiehays
fix: telemetry failure should not cause CLI failure (datahub-project#…
e594136 
…4406)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rslanka rslanka rslanka left review comments

@shirshanka shirshanka shirshanka approved these changes

@kevinhu kevinhu kevinhu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@anshbansal @shirshanka @kevinhu @rslanka