Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(docker): datahub-gms - add jetty configuration xml #4435

Merged
merged 2 commits into from
Mar 30, 2022

Conversation

zhoxie-cisco
Copy link
Contributor

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

@zhoxie-cisco
Copy link
Contributor Author

We got 431 error msg when the request cookies were so large.

Bad Message 431

reason: Request Header Fields Too Large
we located the error in org.eclipse.jetty.httpHttpParser line 796 in version org.eclipse.jetty:jetty-http:9.4.20v20190813 this config allow us to change maxHeaderBytes in jetty to fix this error.

@github-actions
Copy link

github-actions bot commented Mar 17, 2022

Unit Test Results (build & test)

  92 files  +17    92 suites  +17   20m 35s ⏱️ -36s
674 tests +49  615 ✔️ +50  59 💤 ±0  0  - 1 

Results for commit 2f2b46e. ± Comparison against base commit 2d82531.

♻️ This comment has been updated with latest results.

@gabe-lyons
Copy link
Contributor

looks good!

@gabe-lyons gabe-lyons merged commit 14df3cf into datahub-project:master Mar 30, 2022
maggiehays pushed a commit to maggiehays/datahub that referenced this pull request Aug 1, 2022
…ect#4435)

* Add jetty cofig xml to change requestHeaderSize.

* Add jetty config in docker-compose.dev.yml

Co-authored-by: zhoxie-cisco <xiezhongjie1109@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants