Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI-Fix/Secret-form-validation-updated #4500

Merged
merged 1 commit into from
Mar 28, 2022
Merged

UI-Fix/Secret-form-validation-updated #4500

merged 1 commit into from
Mar 28, 2022

Conversation

ShubhamThakre
Copy link
Contributor

Checklist

  • secrets form validation added - > added underscore too in form validation

Screenshot 2022-03-25 at 11 57 45 PM

@jjoyce0510

@github-actions
Copy link

Unit Test Results (build & test)

  92 files  ±0    92 suites  ±0   41m 43s ⏱️ + 24m 37s
674 tests ±0  615 ✔️ ±0  59 💤 ±0  0 ❌ ±0 

Results for commit 48a2d30. ± Comparison against base commit ab36ac0f.

@jjoyce0510 jjoyce0510 merged commit 31c1fe9 into datahub-project:master Mar 28, 2022
maggiehays pushed a commit to maggiehays/datahub that referenced this pull request Aug 1, 2022
@ShubhamThakre @maggiehays
SecretBuilderModal -> name field validation updated (datahub-project#…
139eaa0 
…4500)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjoyce0510 jjoyce0510 jjoyce0510 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ShubhamThakre @jjoyce0510